ns3154 commented on PR #16350: URL: https://github.com/apache/dubbo/pull/16350#issuecomment-4779303454
Thanks for the suggestion, @zrlw! That's a fair point — both methods have no internal callers today. I chose to fix rather than delete because `StringUtils` is a public class and these are public methods: removing them could silently break any downstream project that happens to use them. Fixing the documented contract felt like the safer, non-breaking option. Happy to defer to the team's preference if deletion is favoured, though! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
