AlexStocks commented on code in PR #3449: URL: https://github.com/apache/dubbo-go/pull/3449#discussion_r3464055681
########## config/doc.go: ########## @@ -1,21 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -// Package config assembles all Dubbo configurations and works as the entrance of the whole Dubbo process. Review Comment: [P0] 这个 PR 直接删掉整个 `config/` 包，但仓库里仍有大量未改文件继续依赖它，当前 diff 没有把这些引用一起迁走。按现有仓库内容，至少 `compat.go`、`remoting/getty/getty_{client,server}.go`、`graceful_shutdown/shutdown.go`、`filter/graceful_shutdown/*`、`protocol/rest/config/reader/*`、`dubbo_test.go` 还在 import `dubbo.apache.org/dubbo-go/v3/config` 或构造 `config.*` 类型。也就是说，这里不是单纯的包内重构，而是会把仓库剩余代码直接打成 unresolved import / unknown type。删除 `config/` 包之前，必须先把这些调用点全部迁到新的 API 或兼容层。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
