AlexStocks commented on code in PR #1113:
URL: https://github.com/apache/dubbo-go-samples/pull/1113#discussion_r3464055656
##########
start_integrate_test.sh:
##########
@@ -61,7 +61,7 @@ array+=("retry")
array+=("rpc/grpc")
array+=("rpc/multi-protocols")
array+=("rpc/triple/instance")
-array+=("rpc/triple/old_triple")
+# array+=("rpc/triple/old_triple")
Review Comment:
[P1] 这里把 `rpc/triple/old_triple` 直接从集成测试列表里注释掉了，但这个 PR 同时又改了 `old_triple` 的
server/client 启动路径。结果是：这部分最需要回归验证的样例，反而在本 PR
里失去了集成覆盖。除非这里能给出明确的下线/弃用说明，否则不应该通过“禁测”来带着行为改动一起合入；至少要保留覆盖，或者补上等价的新验证路径。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
