222twotwotwo opened a new pull request, #136: URL: https://github.com/apache/dubbo-getty/pull/136
<!-- Thanks for sending a pull request! --> **What this PR does**: Closes the upgraded WebSocket connection when a self-connect request is rejected, preventing the socket/resource from leaking on that path. Also adds a regression test covering the upgraded self-connect branch and verifying that: - the WebSocket upgrade succeeds - session creation is skipped - the upgraded connection is closed before returning **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_* --> Fixes #132 **Special notes for your reviewer**: Tested with: ```bash go test -run TestWSServeWSRequestClosesSelfConnectConn -count=1 go test ./... -count=1 go vet ./... git diff --check ``` **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". --> ```release-note NONE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
