AlexStocks commented on code in PR #3498:
URL: https://github.com/apache/dubbo-go/pull/3498#discussion_r3610043511
##########
protocol/dubbo/hessian2/hessian_response.go:
##########
@@ -41,51 +41,6 @@ type DubboResponse struct {
Attachments map[string]any
}
-// GenericException keeps Java exception class and message.
-type GenericException struct {
Review Comment:
[P1] 保留已发布的异常 API 兼容入口
`GenericException` 和 `ToGenericException` 已随
`v3.3.2-20260419`、`v3.3.2-20260709` 发布,外部调用方可以直接导入 `protocol/dubbo/hessian2`
使用它们。基于 `v3.3.2-20260709` 的消费者探针在 Base 编译通过,替换为本 PR Head 后稳定报 `undefined:
dubbohessian.GenericException` 和 `undefined:
dubbohessian.ToGenericException`,因此当前删除会让既有用户升级后直接编译失败。建议在原包保留 `type
GenericException = hessian.GenericException`,并保留带 `Deprecated:` 注释的
`ToGenericException` 转发函数;同时补一个外部包编译测试,确认旧导入路径仍可用。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]