AlexStocks commented on code in PR #3469:
URL: https://github.com/apache/dubbo-go/pull/3469#discussion_r3627195194
##########
global/reference_config.go:
##########
@@ -49,15 +49,26 @@ type ReferenceConfig struct {
// config
MethodsConfig []*MethodConfig `yaml:"methods" json:"methods,omitempty"
property:"methods"`
// TODO: rename protocol_config to protocol when publish 4.0.0.
+ //
+ // Deprecated: this implemention will be removed in the next version,
+ // use "tripleConfig" instead
Review Comment:
[P1] 这里给出的迁移入口实际不存在
`ReferenceConfig` 没有可直接替代本字段的 `TripleConfig`；当前客户端 Triple 配置只能通过
`ProtocolClientConfig.TripleConfig` 进入，紧邻的 TODO 也写的是 4.0.0 将 `protocol_config`
重命名为 `protocol`。如果下游按这条弃用说明停止使用或后续删除 `ProtocolClientConfig`，就没有位置承载客户端 Triple
配置。请先新增并验证真实的替代字段与 YAML/JSON 兼容层后再标记弃用；否则应撤销本字段的 `Deprecated:` 标记，并把计划明确为 4.0.0
的重命名。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
