Alanxtl commented on code in PR #3502:
URL: https://github.com/apache/dubbo-go/pull/3502#discussion_r3652366958
##########
common/url.go:
##########
@@ -419,7 +419,7 @@ func (c *URL) String() string {
if len(c.Username) != 0 || len(c.Password) != 0 {
buf.WriteString(c.Username)
buf.WriteString(":")
- buf.WriteString(c.Password)
+ buf.WriteString("******")
Review Comment:
why you change these lines like this?
##########
common/url_test.go:
##########
@@ -1312,7 +1312,7 @@ func TestURLStringWithAuth(t *testing.T) {
// #nosec G101 - test credential for URL string test
u, _ := NewURL("dubbo://" + userName + ":" + testPassword + "@" +
loopbackAddress + ":" + testPort + "/com.test.Service?key=value")
str := u.String()
- assert.Contains(t, str, userName+":"+testPassword+"@")
+ assert.Contains(t, str, userName+":******@")
Review Comment:
?? ditto
##########
tools/benchmark/scripts/gen_code.sh:
##########
@@ -0,0 +1,34 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -e
+
+BASE_DIR=$(cd "$(dirname "$0")/.." && pwd)
+PROTO_DIR="$BASE_DIR/proto"
+OUT_DIR="$PROTO_DIR"
+
+mkdir -p "$OUT_DIR"
+
+echo "[INFO] Generating protobuf code..."
+protoc --proto_path="$PROTO_DIR" --go_out="$OUT_DIR"
--go_opt=paths=source_relative "benchmark.proto"
+
+echo "[INFO] Generating triple code..."
+protoc --proto_path="$PROTO_DIR" --go-triple_out="$OUT_DIR" "benchmark.proto"
Review Comment:
为什么triple的idl不是用protoc-gen-triple生成的
##########
tools/dubbogo-cli/cmd/install.go:
##########
Review Comment:
为什么你改了这么多和你的内容完全无关的文件 如果这些你觉得非常要必要修改单独开一个pr 这个pr只用于benchmark这个事情
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
