Copilot commented on code in PR #3579:
URL: https://github.com/apache/dubbo-go/pull/3579#discussion_r3687383361
##########
protocol/rest/server/rest_server.go:
##########
@@ -110,7 +109,17 @@ func GetRouteFunc(invoker base.Invoker, methodConfig
*rest_config.RestMethodConf
logger.Errorf("[Rest][Server] write error
string failed, err=%v", err)
}
}
- result := invoker.Invoke(context.Background(),
invocation.NewRPCInvocation(methodConfig.MethodName, args,
make(map[string]any)))
+ rawRequest := req.RawRequest()
Review Comment:
After failing to parse request parameters, the handler writes an error
response but continues execution and can still invoke the service (and
potentially write a second response). It should return immediately after
`WriteError` succeeds/fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
