Modo-me commented on code in PR #3498:
URL: https://github.com/apache/dubbo-go/pull/3498#discussion_r3688130693
##########
protocol/dubbo/hessian2/hessian_response.go:
##########
@@ -34,20 +34,15 @@ import (
perrors "github.com/pkg/errors"
)
-// DubboResponse dubbo response
-type DubboResponse struct {
- RspObj any
- Exception error
- Attachments map[string]any
-}
-
-// GenericException keeps Java exception class and message.
+// GenericException is a type alias of hessian.GenericException for backward
Review Comment:
这里不应该改为`type GenericException =
hessian.GenericException`，否则以后上游dubbo-go-hessian2发生变动则会影响dubbo-go下游使用旧版GenericException的兼容性
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
