nightcityblade commented on code in PR #3580:
URL: https://github.com/apache/dubbo-go/pull/3580#discussion_r3694174690
##########
otel/trace/exporter.go:
##########
@@ -74,7 +74,7 @@ func NewExporter(config *ExporterConfig, customFunc func()
(sdktrace.SpanExporte
exporter, err := customFunc()
if err != nil {
- err = fmt.Errorf("failed to create %s exporter: %v",
config.Exporter, err)
+ err = fmt.Errorf("failed to create %s exporter: %w",
config.Exporter, err)
Review Comment:
Addressed in 3806e50. The test now keeps the original cause and verifies it
with require.ErrorIs.
##########
protocol/triple/reflection/serverreflection.go:
##########
@@ -166,7 +167,7 @@ func (s *ReflectionServer) ServerReflectionInfo(ctx
context.Context, stream rpb.
sentFileDescriptors := make(map[string]bool)
for {
in, err := stream.Recv()
- if err == io.EOF {
+ if errors.Is(err, io.EOF) {
Review Comment:
Addressed in 3806e50. Added a fake-stream regression test covering both
wrapped EOF completion and propagation of a non-EOF receive error. The two
affected packages pass go test, and targeted golangci-lint reports 0 issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
