Copilot commented on code in PR #3597: URL: https://github.com/apache/dubbo-go/pull/3597#discussion_r3718235278
########## README.md: ########## @@ -17,9 +17,9 @@ You can visit [the official website](https://dubbo.apache.org/) for more informa For detailed changes, refer to [CHANGELOG.md](CHANGELOG.md). -- **3.3.2**: +- **[3.3.2](https://github.com/apache/dubbo-go/releases/tag/v3.3.2)**: - ***BREAKING CHANGE***: `config` package has been removed, please use modern `global` package, check [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) for usage instructions. + **Upgrade note:** Go 1.25 or later is required. The legacy `config` package has been removed; applications that imported it directly must migrate to the instance/options APIs and configuration types under `global`. See the [3.3.2 changelog](CHANGELOG.md#332) and [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) for migration details and current usage. Review Comment: The root README files appear to have their language entry points reversed: `README.md` currently contains Chinese headings/content (e.g., “## 近期更新”), while `README_CN.md` contains the English version. This makes the documented “entry points” confusing for readers and seems to contradict the PR goal of aligning English/Chinese READMEs. Consider swapping the contents (or renaming the files) and updating the language-switch links so `README.md` is English and `README_CN.md` is Chinese (or vice versa, but consistently). ########## README_CN.md: ########## @@ -15,11 +15,25 @@ 您可以访问 [官网](https://dubbo.apache.org/) 以获取更多信息。 +## 近期更新 + +详细变更请参阅 [CHANGELOG.md](CHANGELOG.md)。 Review Comment: `README_CN.md` currently contains the English README text (e.g., “## Recent Updates”), while `README.md` contains the Chinese text. This reversal makes it hard to navigate between languages and undermines the stated goal of aligning the README entry points. Please swap the contents (or rename the files) and ensure the language-switch links point to the opposite-language file consistently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
