soumadipcodeEnthusiast commented on issue #16397: URL: https://github.com/apache/dubbo/issues/16397#issuecomment-5200816560
@LI123456mo @Sirius-LiXiaoQi following up on the open question about markReadonly() — a few things I wasn't sure about before attempting anything: Is markReadonly() meant to be invoked from the existing shutdown-hook path (e.g. DubboShutdownHook / ApplicationModel destroy callbacks) before unexportServices() runs — flipped once per TripleProtocol instance? Or does it need to be scoped per exported service/invoker, in case shutdown and re-export can race for different services on the same JVM? Is this meant to reuse/relate to the existing "readonly" notification mechanism that Dubbo already sends to consumers for the dubbo:// protocol, or is it a new flag specific to TripleProtocol#afterUnExport? If pathResolver.unregister() is deferred until destroy(), does destroy() need its own bounded wait tied to dubbo.service.shutdown.wait, or does it just run naturally after that timeout has already elapsed elsewhere in the shutdown sequence? @LI123456mo — since #16398 already addresses the UNIMPLEMENTED→UNAVAILABLE side, would it make sense for me to pick up the readonly/deferred-unregister piece as a follow-on PR on top of yours? Or are you planning to fold that in already? Happy to take a first pass if not — just don't want to duplicate effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
