lizining1231 commented on code in PR #3590:
URL: https://github.com/apache/dubbo-go/pull/3590#discussion_r3728522358
##########
Makefile:
##########
@@ -40,6 +41,12 @@ test: clean
GOTOOLCHAIN=go1.25.0+auto go test ./... -coverprofile=coverage.txt
-covermode=atomic
cd $(CLI_DIR) && GOTOOLCHAIN=go1.25.0+auto go test ./...
+# Run race detector on packages that start background goroutines in tests.
+# TestServiceDiscoveryRegistryUnRegister_Concurrent intentionally simulates a
+# data race, so it is excluded from the race detector via -skip.
+test-race:
+ GOTOOLCHAIN=go1.25.0+auto go test -race ./registry/servicediscovery/...
-skip '^TestServiceDiscoveryRegistryUnRegister_Concurrent$$'
+
Review Comment:
@Alanxtl 你好，这里是否可以参考这些选项进行决策？
1. 保持原样不做全局-race;
2. 做全局-race，用`-skip`跳过这些测试;
3. 做全局-race，用`build tag //go:build !race`跳过这些测试。
另外无论最终，我都会持续积极核实这些报错的源头；若确为仓库代码的问题，我会单独提 issue 与 修复 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
