MaoMengww opened a new pull request, #3604:
URL: https://github.com/apache/dubbo-go/pull/3604

   ### Description
   Fixes # (issue)
   The root cause of the bug is an inverted guard condition. When a user use 
RegistryIDs/ProtocolIDs, a non-empty value should be written to the field; 
however, due to the inverted guard condition, the assignment is skipped 
whenever the user provides a value (i.e., len(IDs) > 0), causing it to be 
silently dropped. The test file: when a non-empty value is passed, the 
assertion should be that the field equals the input (assert.Equal), not that it 
differs (assert.NotEqual).
   
   Refs https://github.com/apache/dubbo-go/issues/3598 (task1)
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to