AlexStocks commented on code in PR #3605:
URL: https://github.com/apache/dubbo-go/pull/3605#discussion_r3733584514
##########
metrics/metadata/collector.go:
##########
@@ -58,6 +58,14 @@ func (c *MetadataMetricCollector) start() {
c.handleMetadataSub(event)
case SubscribeServiceRt:
c.handleSubscribeService(event)
+ case MetadataMappingRegister:
Review Comment:
[P1] 补上事件总线到 mapping 指标的生产链回归测试
当前测试分别验证了 DelegateMetadataReport 会发布 mapping 事件，以及四个 handler 被直接调用时会写
registry，但没有经过 start() 中这段生产分发。我在 exact Head 的隔离副本中只删除这四个新增 switch case 后，go
test ./metadata ./metadata/mapping/metadata ./metrics/metadata -count=1
仍全部通过；真实 mapping 操作会继续发布事件，但新增指标永远不会进入 registry。请补一条启动 collector、经真实总线发布事件并断言
registry counter/RT 的测试，删除任一分发 case 时该测试应失败。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
