EmptyCity-111 commented on issue #3598: URL: https://github.com/apache/dubbo-go/issues/3598#issuecomment-5214575535
I opened draft PR #3613 for task 5. The implementation makes `TripleConfig` the single owner of the Triple message-size settings and their `4mib` default. It still writes the same legacy URL parameters in `server/action.go`, so the downstream protocol path is unchanged. I also added regression coverage and updated the JSON schema; the full local test, vet, and lint suites pass. One compatibility point is called out in the PR: removing the two exported fields from `ProtocolConfig` is a Go source-level breaking change, although their comments previously said they would be removed in v4. Could a maintainer confirm whether task 5 expects that removal now, or whether the old fields should remain deprecated until v4? I will mark the PR ready once that direction is clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
