014-code commented on PR #16411: URL: https://github.com/apache/dubbo/pull/16411#issuecomment-5216583003
> Hi @zrlw , have tried reviewing this PR which fixes the issue . But , there is also another PR #16412 which also targets the same issue , can you help review that one so that we compare the two Thanks for pointing out #16412. I compared both implementations and updated this PR to combine their strengths. This PR keeps the generic, idempotent HttpRequest.close() abstraction and the single-commit history based on the current 3.3 branch. It now adopts the safer response-termination lifecycle from #16412: remote cancellation no longer destroys multipart data immediately, and the decoder is released only after application or response processing reaches a terminal state. The updated tests cover normal form completion, HTTP/1 exceptional completion, HTTP/2 remote cancellation with multipart data remaining readable, cleanup after asynchronous success and failure, idempotent observer termination, and custom request implementations. This avoids premature multipart cleanup while ensuring that Netty's DefaultHttpDataFactory entries are released on every terminal path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
