Anon2Tokyo opened a new pull request, #16416:
URL: https://github.com/apache/dubbo/pull/16416

   ## What is the purpose of the change?
   
   Fixes #16414.
   
   This change fixes the gRPC no-stub method discovery path for Triple 
streaming requests. The lazy method discovery listener now reuses the stream's 
existing `StreamingDecoder` instead of creating a temporary 
`GrpcStreamingDecoder`, so buffered bytes from a subsequent message are 
preserved when the listener switches to the resolved business handler.
   
   The close callback on the temporary method-discovery listener is also made a 
no-op because it only exists to resolve the method descriptor and should not 
close the actual request stream.
   
   A regression test covers a DATA-frame layout where the first decode contains 
one complete gRPC message followed by the prefix of the next message, then 
verifies the second message is still decoded after the listener switch.
   
   ## Checklist
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   
   Test:
   
   ```powershell
   mvn.cmd -pl dubbo-rpc/dubbo-rpc-triple -Dtest=GrpcStreamingDecoderTest test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to