XnLemon commented on code in PR #3579:
URL: https://github.com/apache/dubbo-go/pull/3579#discussion_r3763826365
##########
protocol/jsonrpc/server.go:
##########
@@ -270,7 +355,7 @@ func (s *Server) Stop() {
})
}
-func serveRequest(ctx context.Context, header map[string]string, body []byte,
conn net.Conn) error {
+func serveRequest(ctx context.Context, header map[string]string, body []byte,
writer io.Writer) error {
Review Comment:
因为我在前面fix部分的修改加上这里的手写 Content-Type 导致sonar在
7ec7a8770843d8a67197902179cbb0682874d77f 报红说 要把多次手写导出为可复用常量
所以我统一导出为 ontentTypeHeader = "Content-Type" 后 都fix一下
然后在 acdb1d4a6f046c2e6df5da5d0b15731006c1b634 内进行了修改后这里报 32 complexity
我是回退到手写Content-Type 还是把这里拆一下 @Alanxtl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
