Copilot commented on code in PR #1144:
URL: https://github.com/apache/dubbo-go-samples/pull/1144#discussion_r3888504734
##########
generic/go-client/cmd/client.go:
##########
@@ -79,7 +79,8 @@ func main() {
logger.Info("Connected to server via direct URL, starting tests...")
failed := false
- failed = runGenericTests(&genericService{conn: conn}) || failed
+ failed = runGenericTests(genericService.Invoke) || failed
+ failed = runTypedResultTests(cli) || failed
Review Comment:
The PR description says it adds “unit tests” and that integration tests run
them before starting the service, but here the new checks are implemented as
functions executed from `main()` (so they won’t run under `go test` or in CI
unless someone runs this sample). Either add real `*_test.go` tests for these
scenarios, or update the PR description/docs and naming to reflect that these
are runtime sample checks rather than unit/integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
