Alanxtl commented on code in PR #3713:
URL: https://github.com/apache/dubbo-go/pull/3713#discussion_r3894975456


##########
filter/accesslog/filter.go:
##########
@@ -90,19 +90,28 @@ type Filter struct {
        ctx          context.Context
        cancel       context.CancelFunc
        shutdownOnce sync.Once
+       started      chan struct{} // closed once processLogs is running
+       done         chan struct{} // closed once processLogs has exited

Review Comment:
   能不能只改test不改主代码 主代码这样改没有意义呀



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to