cuishuang opened a new issue, #16451: URL: https://github.com/apache/dubbo/issues/16451
### Pre-check - [x] I am sure that all the content I provide is in English. ### Search before asking - [x] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar issues. ### Apache Dubbo Component Java SDK (apache/dubbo) ### Dubbo Version Apache Dubbo 3.3 branch, JDK 8 or later, any operating system. ### Steps to reproduce this issue `Bytes.getMD5(InputStream)` uses `InputStream.available()` as an EOF check and updates the message digest with the entire buffer instead of the number of bytes actually read. For example, the bundled `md5.testfile.txt` contains only: ```text hello world! ``` Calling `Bytes.getMD5(File)` returns the Base64 value: ```text iNZ+5qHafVNPLJxHwLKJ3w== ``` The correct MD5 of `hello world!` is: ```text /D/5joxqDTCH1RXARz+Gdw== ``` The same problem occurs for an `InputStream` whose final read is shorter than 8192 bytes. ### What you expected to happen `Bytes.getMD5(InputStream)` and `Bytes.getMD5(File)` should calculate the MD5 of exactly the bytes supplied by the input source. ### Anything else The implementation should read until `read()` returns `-1` and update the digest with only the bytes returned by each read: ```java int read; while ((read = is.read(buf)) != -1) { md.update(buf, 0, read); } ``` A pull request is prepared with tests for 12, 8191, 8192, and 8193 byte inputs, plus an input stream whose `available()` method returns zero while data is still readable. ### Do you have a (mini) reproduction demo? - [x] Yes, I have a minimal reproduction demo to help resolve this issue more effectively! ### Are you willing to submit a pull request to fix on your own? - [x] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
