Alanxtl commented on code in PR #1147:
URL: https://github.com/apache/dubbo-go-samples/pull/1147#discussion_r3956689335
##########
go.mod:
##########
@@ -3,13 +3,13 @@ module github.com/apache/dubbo-go-samples
go 1.25.0
require (
- dubbo.apache.org/dubbo-go/v3 v3.3.2-20260419
+ dubbo.apache.org/dubbo-go/v3 v3.3.3-0.20260906090102-5f54b6a8cc97
Review Comment:
哪有这个tag？
##########
http3/go-client/cmd/main.go:
##########
@@ -52,7 +64,15 @@ func main() {
// both HTTP/2 and HTTP/3 with Alt-Svc negotiation
client.WithClientProtocol(
protocol.WithTriple(
- triple.Http3Enable(),
+ triple.WithHttp3Enable(),
+
triple.WithHttp3KeepAlivePeriod(quicKeepAlivePeriod),
+
triple.WithHttp3MaxIdleTimeout(quicMaxIdleTimeout),
+
triple.WithHttp3MaxIncomingStreams(quicMaxIncomingStreams),
+
triple.WithHttp3MaxIncomingUniStreams(quicMaxIncomingUniStreams),
+
triple.WithHttp3InitialStreamReceiveWindow(quicInitialStreamReceiveWindow),
+
triple.WithHttp3MaxStreamReceiveWindow(quicMaxStreamReceiveWindow),
+
triple.WithHttp3InitialConnectionReceiveWindow(quicInitialConnectionReceiveWindow),
+
triple.WithHttp3MaxConnectionReceiveWindow(quicMaxConnectionReceiveWindow),
Review Comment:
加一下针对这些参数的测试呀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
