let's revisit this when we enhance unit test in config-api. In my opinion, config-api's unit test needs to clean up:
1. as you mentioned, not only 'mock protocol' but also other constants are needed to defined as constants. 2. there are some test cases depends on other module which may lead to cycle dependency in the future, for example: 'dubbo-registry-multicast' should not be used by 'dubbo-config-api'. In this pull request, I solved some of cycle dependencies when I start to use 'dubbo-config-api' in 'dubbo-rpc-dubbo'. We should address others in another delegated change. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/3013 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
