EarthChen opened a new pull request, #1304:
URL: https://github.com/apache/dubbo-samples/pull/1304

   ## Summary
   
   ```diff
    dubbo-samples-configcenter-externalconfiguration/pom.xml
   
    <properties>
      <spring-boot.version>1.5.22.RELEASE</spring-boot.version>
   +  <spring.version>5.3.24</spring.version>
   
    <dependencyManagement>
      <dependencies>
   +    <import>spring-framework-bom:${spring.version}</import>   <!-- first: 
wins -->
        <import>spring-boot-dependencies:1.5.22</import>          <!-- manages 
spring 4.3.25 -->
   ```
   
   Why: `spring-boot-dependencies:1.5.22` manages Spring Framework at 
`4.3.25.RELEASE`. Spring 4.3 cglib cannot run on JDK 16+ 
(`InaccessibleObjectException`), so the CI scenario 
`configcenter-externalconfiguration` must resolve Spring 5.x on the JDK 21 
matrix. Previously that only worked by accident: under Maven 3.9.x the CI's 
`-Dspring.version=5.3.24` leaked into the remote BOM's `${spring.version}` 
property; Maven 3.10.0 restricts interpolation of remotely resolved models 
([release notes — Security 
Hardening](https://maven.apache.org/docs/3.10.0/release-notes.html)), so the 
override silently stopped working when the `ubuntu-22.04` runner image upgraded 
Maven (20260828.587 → 20261002.596). Moving the version pin into the local POM 
makes the override deterministic on every Maven version.
   
   ## Evidence
   
   - **Before:** `dubbo-samples-configcenter-externalconfiguration` times out 
(600s) on the Dubbo CI Java 21 matrix ([apache/dubbo run 
38043764351](https://github.com/apache/dubbo/actions/runs/38043764351/job/114190189352)):
   
     ```
     java.lang.InaccessibleObjectException: Unable to make ... 
java.lang.ClassLoader.defineClass(...)
       accessible: module java.base does not "opens java.lang" to unnamed module
       at 
org.springframework.cglib.core.ReflectUtils$1.run(ReflectUtils.java:61) 
~[spring-core-4.3.25.RELEASE.jar:...]
     Wrapped by: java.lang.IllegalStateException: Cannot load configuration 
class:
       
org.apache.dubbo.samples.externalconfiguration.provider.AnnotationProvider
     ```
   
     Reproduced locally with Maven 3.10.0 (same as the failing CI image): `mvn 
dependency:tree -Dspring.version=5.3.24` still resolves 
`org.springframework:spring-core:jar:4.3.25.RELEASE`.
   
     **After:** same command on this branch resolves:
   
     ```
     org.springframework:spring-core:jar:5.3.24:compile
     org.springframework:spring-jcl:jar:5.3.24:compile
     ```
   
     — the exact combination that ran green before the runner image update (run 
35845285402, 2026-09-23, passed in 28s). Also verified: without `-D` the 
default `5.3.24` applies; `-Dspring.version=6.1.5` overrides as expected; 
Spring Boot stays at `1.5.22.RELEASE`; JDK 8 matrix unaffected (Spring 5.3 
supports Java 8+). The Dubbo CI on this PR is the end-to-end confirmation.
   
   ## Merge Danger
   
   **Door:** two-way — a 12-line revertable POM change to one sample module, no 
library or workflow code touched.
   
   **Blast Radius:** single sample 
(`dubbo-samples-configcenter-externalconfiguration`) plus its 
`case-versions.conf` behaviour, which already declares `spring.version=4.*, 
5.*`, so the CI matrix contract is unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to