AsperforMias opened a new issue, #3768:
URL: https://github.com/apache/dubbo-go/issues/3768

   ### What problem would this solve?
   
   [OSPP 
262e80018](https://summer.ospp.ac.cn/org/prodetail/262e80018?list=org&navpage=org&lang=zh)
 requires Admin's existing service/application condition routes and instance 
traffic switches to take effect in Go. apache/dubbo-admin#1523 is the broad 
router-alignment tracker. Go already has condition parsers and routing tests, 
but a focused, source-backed compatibility case should connect the existing 
Admin payload, config key/path, initial rule load and change/delete events to 
the actual selected Go providers.
   
   This is a compatibility-verification task, not a claim that condition 
routing is missing. Any newly reproduced defect should be isolated with its 
smallest regression and fix.
   
   I would like to take this bounded OSPP slice; requested assignee: 
@AsperforMias.
   
   ### Proposed solution (optional)
   
   Add reusable Admin-produced condition-rule fixtures and deterministic 
Go-side compatibility coverage, building on the existing 
condition/config-center tests.
   
   Acceptance criteria:
   
   - [ ] Pin the Admin source revision used to obtain fixtures. Use its current 
condition rules (including its actual `configVersion`), rather than the pending 
affinity/script resources.
   - [ ] Cover service scope with interface/group/version and application scope 
with distinct consumer/provider application names. Assert the exact 
lookup/listener keys actually generated by both sides, including 
namespace/group/path handling for Nacos and ZooKeeper.
   - [ ] Exercise rule present before subscription, subsequent update, explicit 
enable/disable and deletion. Assert selected provider identities through the 
normal router path, not only successful YAML parsing.
   - [ ] Include the existing Admin instance-disable condition 
(`=>host!=<IP>`): selected instance A is excluded while B remains; re-enabling 
A restores it without dropping unrelated conditions. Verify the configured 
forced-empty result does not fall back to the banned provider when all 
candidates are excluded.
   - [ ] Record supported version/field defaults and 
unsupported/malformed-payload behavior. Preserve existing governance semantics 
unless a source-backed compatibility defect is demonstrated.
   - [ ] Provide local automated commands using the existing fake 
config-center/listener facilities, plus a concise real config-center/RPC 
validation recipe. Distinguish in-process assertions from an actual deployment 
run; external-service tests must report their prerequisites and skips honestly.
   
   Starting points: [Go condition 
factories/listeners](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/condition/dynamic_router.go),
 [existing 
tests](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/condition/router_test.go),
 [Go config-center 
options](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/config_center/dynamic_configuration.go),
 [Admin condition 
service](https://github.com/apache/dubbo-admin/blob/b9ee1b779fd7e87d0097edb5645e9c9176a917a7/pkg/console/service/condition_rule.go),
 and [Admin instance traffic 
switches](https://github.com/apache/dubbo-admin/blob/b9ee1b779fd7e87d0097edb5645e9c9176a917a7/pkg/console/service/instance.go).
   
   Independence and boundaries:
   
   - Implement directly on current Go `develop`; fixtures may be obtained from 
already merged Admin `develop@b9ee1b7`.
   - No dependency on apache/dubbo-admin#1552–apache/dubbo-admin#1556, their 
branches, codecs, DTOs, history/rollback paths or UI. No affinity/script router 
or script-timeout work.
   - This task can be reviewed/merged independently of tag-route and 
observability fixture work. Reuse shared helpers only after they are upstream, 
rather than stacking PRs.
   - Keep application-level discovery/metadata as the runtime model. Do not 
restore interface-level discovery or change metadata publication, configurator 
#3661/#3660, or the broader existing router model.
   
   Related: apache/dubbo-admin#1523. This issue is limited to existing 
condition-route/instance-switch compatibility and does not close that umbrella.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to