AsperforMias opened a new pull request, #1595:
URL: https://github.com/apache/dubbo-admin/pull/1595

   **Please provide a description of this PR:**
   
   Disabling a condition or tag rule drops `enabled: false` from the stored 
YAML because the protobuf fields use `omitempty`. A Go tag router then treats 
that rule as enabled; older condition parsing can also panic on missing flags.
   
   Keep `enabled`, `force` and `runtime` explicit for these two rule types in 
the Nacos and ZooKeeper writers. Other resource types keep their existing 
encoding.
   
   Refs apache/dubbo-go#3768 and apache/dubbo-go#3769.
   
   Validation: regression tests fail before the change and pass afterward. 
`make fmt`, `make test`, the UI build required by Go embedding, and 
resource/governor package race checks pass. The actual writer output was 
recaptured from ZooKeeper and used in real Dubbo-Go condition/tag RPC checks.
   
   **To help us figure out who should review this PR, please put an X in all 
the areas that this PR affects.**
   
   - [ ] Docs
   - [ ] Installation
   - [ ] User Experience
   - [ ] Dubboctl
   - [ ] Console
   - [x] Core Component
   
   **Please check any characteristics that apply to this pull request.**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to