AsperforMias opened a new pull request, #3770: URL: https://github.com/apache/dubbo-go/pull/3770
### Description Consumer RPC metrics use the provider's application name/version after registry discovery merges the provider and reference URLs. This makes the metric `application_name` differ from the consumer trace resource's `service.name`. Read the local application config from the consumer URL attribute when building metric labels. Keep the provider URL params for routing, and fall back to those params if the local config is absent or invalid. Provider labels keep their current behavior. Refs #3767. Validation: `make fmt` passed. `make test` passed for the root module and CLI. Regular and race tests pass for `./metrics/rpc ./filter/metrics`. New tests fail before the fix for two consumers sharing one provider and pass afterward; they also cover missing/typed-nil attributes and fallback behavior. The existing observability example also passed its strict live capture with a temporary module replacement pointing to this commit: five RPC pairs, 5/4/1 counts on both sides, matching application/service/method fields and context logs. This unmerged checkout was used only for acceptance testing. This corrects the consumer series' application labels; queries using the provider name for consumer metrics will need the consumer application name instead. ### Checklist - [x] I confirm the target branch is `develop` - [x] I have run `make fmt` to format my code - [x] I have run `make test` to run local tests - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
