Alanxtl commented on code in PR #3765:
URL: https://github.com/apache/dubbo-go/pull/3765#discussion_r4291104444


##########
metrics/prometheus/gauge_func.go:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package prometheus
+
+import (
+       "encoding/json"
+       "sort"
+       "sync"
+)
+
+import (
+       prom "github.com/prometheus/client_golang/prometheus"
+)
+
+import (
+       "dubbo.apache.org/dubbo-go/v3/metrics"
+)
+
+// gaugeFuncVec keeps one callback per label set without changing ordinary 
gauges.
+type gaugeFuncVec struct {
+       desc       *prom.Desc
+       labelNames []string
+       mu         sync.RWMutex
+       values     map[string]gaugeFuncValue
+}
+
+type gaugeFuncValue struct {
+       labels []string
+       value  func() float64
+}
+
+func newGaugeFuncVec(m *metrics.MetricId) *gaugeFuncVec {
+       names := m.TagKeys()
+       sort.Strings(names)
+       return &gaugeFuncVec{
+               desc:       prom.NewDesc(m.Name, m.Desc, names, nil),
+               labelNames: names,
+               values:     make(map[string]gaugeFuncValue),
+       }
+}
+
+func (v *gaugeFuncVec) add(tags map[string]string, value func() float64) {
+       if value == nil {
+               panic("metrics: nil gauge function")
+       }
+       if len(tags) != len(v.labelNames) {
+               panic("metrics: inconsistent gauge label cardinality")
+       }
+       labels := make([]string, len(v.labelNames))
+       for i, name := range v.labelNames {
+               var ok bool
+               labels[i], ok = tags[name]
+               if !ok {
+                       panic("metrics: inconsistent gauge label names")
+               }
+       }
+       // Encoding label values avoids collisions when they contain separators.
+       key, _ := json.Marshal(labels)
+       v.mu.Lock()
+       defer v.mu.Unlock()
+       if _, exists := v.values[string(key)]; !exists {
+               v.values[string(key)] = gaugeFuncValue{labels: labels, value: 
value}
+       }

Review Comment:
   对已有标签只保留首次注册的回调。若在同一 registry 
中重建同名、同标签的窗口指标向量,新记录会进入新窗口,但采集仍读取旧窗口;旧窗口过期后,即使新向量持续记录,也会导出 `0` 或 
`NaN`。建议明确处理重复注册,避免静默保留旧窗口,并增加向量重建的回归测试。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to