CCCLL opened a new pull request, #16519: URL: https://github.com/apache/dubbo/pull/16519
## What is the purpose of the change? Follow-up to #16516 (issue #16515), as suggested by @EarthChen in the review of #16516. - Adds `BroadCastClusterInvokerTest#testFailPercentRoundingDownToZero`. The failure threshold is `invokers.size() * broadcast.fail.percent / 100`, so with four providers and `broadcast.fail.percent=10` it is 0, and the broadcast has to stop at the first failed provider, as with a percentage of 0. The test makes the second provider fail, so it also checks that the broadcast does not stop before the first failure, and asserts that the third and fourth providers are not called. - Fixes the code comment in `BroadcastClusterInvoker` that calls the parameter `broadcast.fail.threshold`. The key is `broadcast.fail.percent`, and has been since it was added in #7174. No behavior change. ## Verification - The new test passes on `3.3`. With the #16516 change reverted, it fails at `assertFalse(invoker3.isInvoked())`. - `mvn test -pl dubbo-cluster`: 308 tests, 0 failures (13 skipped, as on the base branch); spotless and checkstyle are clean. ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
