sharanggupta opened a new pull request, #16527:
URL: https://github.com/apache/dubbo/pull/16527

   ## What is the purpose of the change?
   
   Three test methods have no `@Test`, so they never run:
   
   - `ParametersTest.testMap2Parameters` and `testString2Parameters`: the class 
extended JUnit 3's `TestCase` until the upgrade to JUnit 5 in #3149, which 
removed `extends TestCase` without adding `@Test`. The class has had no test 
since.
   - `RegistryConfigTest.testPreferredWithTrueValue`: its counterpart 
`testPreferredWithFalseValue` right below it has `@Test`, but this one does not.
   
   This adds `@Test` to the three methods, and removes their `public` modifier 
like the other test methods (#10977, #10978). They pass.
   
   ## Checklist
   - [ ] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. 
(No issue; this only changes tests.)
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to