yumestk opened a new pull request, #3776:
URL: https://github.com/apache/dubbo-go/pull/3776
### Description
Fixes #3775
Invalid generator parameters were silently accepted because convert
did not check the error returned by options.Generate before overwriting
it during descriptor resolution.
Return the parameter error immediately. Add regression tests for
unsupported formats and unknown parameters, including unknown parameters
before and after a valid format option.
### Validation
- The four new regression cases fail before the fix and pass afterward.
- OpenAPI module: `go test ./... -count=1` passed.
- Real protoc checks: default/YAML/JSON generation succeeds;
invalid parameters fail without generating output files.
- `make fmt` passed.
- `GOTOOLCHAIN=go1.25.0 make test` passed.
- `GOTOOLCHAIN=go1.25.0 make lint` passed with 0 issues.
Repository-level tests and lint were run with Go 1.25.0 to match CI.
### Checklist
- [x] I confirm the target branch is `develop`
- [x] I have run `make fmt` to format my code
- [x] I have run `make test` to run local tests
- [x] I have added tests that prove my fix is effective or that my feature
works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]