binbin0325 opened a new pull request, #16538: URL: https://github.com/apache/dubbo/pull/16538
DefaultSerializationExceptionWrapper is applied as an SPI wrapper to every Serialization, so codecs only ever see ProxyObjectInput / ProxyObjectOutput. Neither proxy implemented Cleanable, which made every "instanceof Cleanable" check in ExchangeCodec, TransportCodec, DecodeableRpcResult and DecodeableRpcInvocation always false, and cleanup() of the wrapped input/output was never invoked. Serializations that release resources in cleanup() leaked them, e.g. a GZIP-based ObjectInput left its native Inflater to the Cleaner and the process ran out of native memory under load. Let both proxies implement Cleanable and forward cleanup() to the target. Fixes #16537 ## What is the purpose of the change? ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
