Qiao-yq commented on PR #1592: URL: https://github.com/apache/dubbo-admin/pull/1592#issuecomment-6392726176
Thanks for the thorough review. I agree with the remaining P2/P3 observations. For this PR, I will keep the current design. `MaintenanceStore` and `SystemAccessContext` are intentional boundaries for trusted in-process code, and ADR 0001 documents that they are not a strict capability-security boundary. The `IsSystem()` branch in `CanAccessOwner` is retained for maintenance and legacy-adoption semantics, while business operations reject system contexts through `ValidateBusiness()`. Stricter system-capability issuance and identity canonicalization can be addressed in follow-up authentication and maintenance hardening work. No further changes are planned for this PR. Thanks for confirming that there are no blocking issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
