b84330808 opened a new pull request, #16550:
URL: https://github.com/apache/dubbo/pull/16550
## What is the purpose of the change?
`AbstractConfig` turns getter/setter names into property names with
`toLowerCase()`/`toUpperCase()`, which follow the JVM default locale. Under a
Turkish default locale `"I".toLowerCase()` is a dotless `"ı"`, so every
property starting with `i` is mangled:
- `appendParameters()` writes `ıothreads=8` instead of `iothreads=8` for
`ProtocolConfig#setIothreads` (same for `interface`, `init`, `injvm`, ...)
- `refresh()` looks up `dubbo.protocol.ıothreads`, so
`dubbo.protocol.iothreads` from system properties / `dubbo.properties` / env is
silently ignored
This uses `Locale.ROOT` in those helpers, as `EnvironmentConfiguration`,
`FixedParamValue` and `SwitchLogLevel` already do. Two tests in
`AbstractConfigTest` set the default locale to `tr-TR`; both fail on `3.3`
(`{ıothreads=8} ==> expected: <8> but was: <null>`) and pass with the change.
I used Claude Code to write this change.
## Checklist
- [ ] Make sure there is a
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
(no separate issue; the description above covers it)
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction.
- [ ] Make sure gitHub actions can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]