sharanggupta opened a new pull request, #16553:
URL: https://github.com/apache/dubbo/pull/16553

   ## What is the purpose of the change?
   
   `ConditionStateRouterTestV31` doesn't match Surefire's default includes, so 
its 9 tests have never run since #14456; this renames it to 
`ConditionStateRouterV31Test`. Four of them then failed: a v3.1 condition 
written as `from:` with no value is rejected as "Illegal route rule!" and the 
whole rule is dropped, while leaving `from` out matches every consumer. 
`MultiDestConditionRouter` now treats a null `from` like an empty one, and the 
dubbo-cluster router tests pass.
   
   ## Checklist
   - [ ] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new 
feature or significant change is committed, please remember to add sample in 
[dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Make sure gitHub actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to