AlexStocks commented on code in PR #3451:
URL: https://github.com/apache/dubbo-go/pull/3451#discussion_r4398982235


##########
tools/dubbogo-cli/generator/application/pkg.go:
##########
@@ -49,9 +49,7 @@ import (
        "dubbo.apache.org/dubbo-go/v3/common/logger"
 )
 
-type GreeterServerImpl struct {
-       api.UnimplementedGreeterServer
-}
+type GreeterServerImpl struct{}

Review Comment:
   [P1] 保留或实现生成服务端所需的流方法
   
   这里移除 `api.UnimplementedGreeterServer` 后,`GreeterServerImpl` 只剩 
`SayHello`,但同一 PR 生成的 `GreeterHandler` 同时要求 `SayHello` 和 
`SayHelloStream`,`RegisterGreeterHandler(srv, &service.GreeterServerImpl{})` 
因此无法编译。`newDemo` 的 `GreeterProvider` 也有同样问题。已用当前 Head 的 committed newApp 
模板验证:仅在验证副本中处理 Base 也存在的旧 logger 导入后,`go build ./cmd` 明确报 `missing method 
SayHelloStream`;仅补上该方法后构建通过。请同步实现流方法或保留可满足新接口的默认适配器,并覆盖 newApp/newDemo 
两种生成项目的服务端构建。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to