AlexStocks opened a new issue, #2:
URL: https://github.com/apache/dubbo-net/issues/2
## 问题
导入进来的 82 个 `.cs` 文件**没有任何 ASF license header**,但仓库根的 `.licenserc.yaml` 已经声明:
```yaml
header:
license:
spdx-id: Apache-2.0
paths-ignore:
- '**/*.md'
- '**/*.csproj'
- ...
```
`.cs` 不在 `paths-ignore` 中,因此一旦接入 skywalking-eyes(`comment: on-failure`
已配置),全量文件都会失败。这也是 ASF release policy 的硬性要求,**阻断发版**。
## 现状
```
$ find . -name "*.cs" -not -path "./.git/*" | wc -l
82
$ grep -rl "Licensed to the Apache Software Foundation" --include=*.cs . |
wc -l
0
```
其中 5 个文件还带着另一套来源声明,需要单独判断:
| 文件 | 现有头部 |
|---|---|
| `NetService/MyWebTool.cs:13` | `Copyright (c) 2015 lijie` |
| `NetService/Telnet/EsTelnet.cs:14` | `Copyright (c) 2017 lijie` |
| `NetService/Telnet/ExTelnet.cs:15` | `Copyright (c) 2017 lijie` |
| `MyCommonHelper/EncryptionHelper/MyEncryption.cs:9` | `Copyright (c) 2015
lijie` |
| `MyCommonHelper/MyExtensionMethods.cs:9` | `Copyright (c) 2015 lijie` |
这 5 个文件自述来自**另一个仓库** `github.com/lulianqi/AutoTest`,并标注 `All rights
reserved`,且头部含个人手机号。它们不能简单套 ASF header —— 需要先确认 SGA 覆盖范围(见 PR #1 讨论),或直接删除。
## 建议做法
1. 用一次独立 commit 机械补齐(避免和逻辑改动混在一起,便于 review):
```bash
# 对每个 .cs 在首个 using/namespace 之前插入 .licenserc.yaml 里那段标准 header
```
2. 先把上述 5 个文件的来源问题(SGA 覆盖 / 删除)确认掉,再决定它们的 header 怎么写。
3. 接入 license-eye 的 CI job,防止回退。
## 验收
- `grep -rl "Licensed to the Apache Software Foundation" --include=*.cs . |
wc -l` 等于 `.cs` 总数(扣除被删除的文件)。
- license-eye 检查通过。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]