lizining1231 commented on PR #3782:
URL: https://github.com/apache/dubbo-go/pull/3782#issuecomment-6541609619

   Thank you all for your review! We have made the corresponding revisions, as 
detailed below:
   
   1. Consolidate the three compression threshold test files (config, default 
behavior, send-limit safety) into a single `response_compression_test.go`. Test 
cases and helpers stay unchanged; only the file layout changes.
   
   2. Compare the cloned threshold directly with `require.Equal` instead of 
converting both sides through `strconv`. The now unused `strconv` import is 
removed.
   
   3. Raise the send limit to 256B in the safety tests and use payloads above 
it, so the expectations no longer depend on how gzip compresses very small 
inputs. Payloads below the capped threshold still assert an uncompressed 
response.
   
   4. Reword the cap documentation to state that the send limit is checked 
against the compressed size, instead of implying that a compressed response 
always fits. Applies to the comments in `server.go`, `triple_config.go` and 
`options.go`.
   
   5. Drop the `triple.` prefix from the service parameter so it matches the 
`server-compress-min-bytes` config key and the unprefixed sibling 
`max-server-send-msg-size`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to