lulianqi opened a new pull request, #13:
URL: https://github.com/apache/dubbo-net/pull/13
### Description
Fixes #12
- Make `README.md` the complete English default repository/package guide,
including translated explanations, architecture labels, and code comments.
- Preserve the existing Chinese documentation in the exact filename
`readme_cn.md`.
- Add reciprocal language links, a contribution-guide link, guidance to
maintain both languages together, and NOTICE references in both versions.
- Preserve API identifiers, executable examples, configuration defaults,
framework requirements, compatibility qualifications, protocol/security limits,
and release/licensing statements.
### Scope
Only `README.md` and `readme_cn.md` change. No runtime code, public APIs,
target frameworks, package version, package configuration, LICENSE, or NOTICE
changes. `PackageReadmeFile` remains `README.md`. No packages were published.
### Validation
- Release solution build passed (0 errors; 4 existing source/analyzer
warnings).
- All **388 unit tests passed**, with no skips.
- License header check: **79 valid, 0 invalid**.
- Temporary documentation consistency checks passed:
- The original Chinese content is intact, apart from language navigation
and the matching contribution/NOTICE additions.
- Both languages have 33 corresponding headings and 50 table rows.
- All 35 fenced blocks are balanced; the executable/signature/path
contents of 34 example blocks match the original after excluding translated
comments. The remaining block is the translated architecture diagram.
- All 15 relative links/anchors across both READMEs resolve with exact
filename case.
- No Chinese prose or comments remain in the English version except the
language-switch label.
- A local-only `dotnet pack` succeeded; the package's README is
byte-identical to the English source, its declared README entry is `README.md`,
and packaged LICENSE/NOTICE are unchanged.
- `git diff --check` passed.
Commands used:
```bash
dotnet build DubboNet.sln --configuration Release
-p:GeneratePackageOnBuild=false
dotnet test Tests/UnitTestForDubboNet/UnitTestForDubboNet.csproj
--configuration Release --no-build --no-restore -p:GeneratePackageOnBuild=false
dotnet pack DubboNet.csproj --configuration Release --no-build --no-restore
-p:GeneratePackageOnBuild=false --output <temporary-directory>
license-eye header check
```
Live RPC/registry tests and the Docker build were not rerun for this
documentation-only change. Existing compatibility claims were translated, not
re-certified.
### Checklist
- [x] The target branch is `main`.
- [x] The commit is signed off and this PR links the corresponding issue.
- [x] Local unit tests pass.
- [x] Both languages, examples, links, and package README entry have been
checked.
- Code formatting (`dotnet format`): not applicable; no source-code changes.
- New runtime tests: not applicable; documentation consistency was checked
separately without adding test code to the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]