NeverENG opened a new pull request, #15:
URL: https://github.com/apache/dubbo-net/pull/15

   ### Description
   Fixes #8
   
   Validate Hessian2 list lengths and class field counts against the remaining 
payload bytes before allocating arrays or lists. Each declared value or field 
name needs at least one wire byte, so counts above the remaining byte count 
cannot describe a valid payload.
   
   Add regression tests for the reported 6/7-byte payloads, truncated inputs, 
response decoding, and valid list/class-definition values.
   
   ### Validation
   - `dotnet test Tests/UnitTestForDubboNet/UnitTestForDubboNet.csproj 
--configuration Release -p:GeneratePackageOnBuild=false`: 396 passed, 0 failed.
   - `dotnet build DubboNet.sln --configuration Release 
-p:GeneratePackageOnBuild=false`: succeeded.
   - `git diff --check`: passed.
   - `dotnet format DubboNet.sln --verify-no-changes --no-restore --include 
DubboService/Native/DubboHessian2Reader.cs 
Tests/UnitTestForDubboNet/HessianResponseSafetyTest.cs`: reports a pre-existing 
whitespace issue at `HessianResponseSafetyTest.cs:46`, unchanged from `main`.
   
   ### Checklist
   - [x] I confirm the target branch is `main`
   - [ ] I have run `dotnet format` to format my code (verification reports the 
unrelated existing whitespace noted above)
   - [x] I have run `dotnet test` to run local tests
   - [x] I have added tests that prove my fix is effective or that my feature 
works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] fix: validate Hessian2 decl... NeverENG (via GitHub) via notifications

Reply via email to