NeverENG opened a new pull request, #18:
URL: https://github.com/apache/dubbo-net/pull/18

   ### Description
   
   Refs #17 (Hessian2 tags only; keep this issue open for the Dubbo frame and 
response-kind follow-ups).
   
   Test-first history: `test: pin Hessian2 tag wire compatibility` precedes 
`refactor: name Hessian2 wire tags by protocol`. The new tests assert **literal 
wire bytes**, never the production constants, for the full double tag `0x44`, 
compact double/int/long boundaries, list tags `0x55–0x58` and `0x70–0x7f`, and 
the adjacent boolean tag. All 30 new cases passed against the unchanged reader 
before implementation.
   
   `Hessian2Tags.cs` now owns only the wire tags and compact encoding 
boundaries used by the dynamic response reader. The reader uses those names for 
dispatch, ranges, and offsets; UTF-8 bit masks and safety limits stay where 
they belong. No codec, frame, error-message, limit, or public API changes.
   
   ### Verification
   
   - Before implementation: new tag contract tests **30 passed**.
   - After implementation: focused tag/response/codec tests **88 passed**; all 
unit tests excluding the unrelated local DNS-dependent test **434 passed**; 
Release solution build passed.
   - `dotnet format DubboNet.sln --include <three changed files> 
--verify-no-changes --no-restore`: passed; `git diff --check`: passed.
   - Full local run before **and** after: **434 passed, 1 failed**. The 
pre-existing failure is 
`TestEndpointOptionsTest.LocalhostResolvesBeforeTheIpOnlyNativeConstructorIsUsed`
 on this host because its `localhost` resolves to non-loopback addresses. Not 
changed in this PR; CI should independently verify its own environment.
   
   ### Checklist
   
   - [x] Target branch is `main`.
   - [x] Ran targeted `dotnet format` verification without reformatting 
unrelated files.
   - [x] Ran relevant local tests and disclosed the full-suite baseline failure 
above.
   - [x] Added independent byte-level tests before touching production code.
   - [x] New C# files carry the ASF license header.
   
   Draft for review of constant naming and ownership; please do not treat this 
as a behavior fix or the completion of #17.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to