wozhenbang2004 opened a new pull request, #673:
URL: https://github.com/apache/dubbo-spi-extensions/pull/673

   ## What is the purpose of the change
   
   A transient failure during a Consul blocking query currently ends the 
background watch. After Consul recovers, the consumer can keep using a stale 
provider list because the watch has stopped.
   
   Fixes apache/dubbo#16573.
   
   ## Brief changelog
   
   - Retry transport failures, HTTP 429 and 5xx with a one-second delay in both 
Consul watch paths. Unsubscribe and thread interruption still stop the watch.
   - Advance the wildcard catalog index after its service lookups succeed, so a 
failed lookup can retry the same catalog revision.
   
   ## Verifying this change
   
   Three regression tests exercise a real loopback HTTP endpoint. They cover 
the interface registry, service discovery, and wildcard subscriptions with a 
failed service lookup. All three fail on the unmodified source and pass with 
the fix. Checkstyle reports zero violations.
   
   `mvn -pl :dubbo-registry-consul -am -Pcheckstyle 
-DskipIntegrationTests=false -Dtest=ConsulWatchRecoveryTest 
-Dsurefire.failIfNoSpecifiedTests=false test`
   
   The existing `ConsulRegistryTest` could not start its embedded Consul 
because the local test environment could not resolve `releases.hashicorp.com`.
   
   - [x] Link the GitHub issue and limit the change to that issue.
   - [x] Use the Dubbo PR title format and meaningful commit subjects.
   - [x] Explain the problem and the change.
   - [x] Add regression tests.
   - [ ] Complete the full repository unit and integration suites.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to