NeverENG opened a new pull request, #22:
URL: https://github.com/apache/dubbo-net/pull/22

   ### Description
   Refs #20 (first ZooKeeper registry-path slice; **do not close #20**). 
Follows the client/registry constant-management phase of #16. This PR is 
independent of Native codec PR #21 and is based on `main`.
   
   - Introduce `Clients/RegistryClient/ZooKeeperRegistryPaths.cs` for the 
ZooKeeper default root, `providers` node/suffix and `/consumers/` directory 
segment.
   - Reuse those definitions at ZooKeeper provider-path construction, 
recognition and root normalization in `DubboClient`, plus consumer 
registration's ZooKeeper path.
   - Keep the Nacos naming group, service name, consumer metadata category, 
Provider URL keys, metadata path category and all configurable defaults outside 
this PR. Equal strings in different registry contracts are not automatically 
the same constant.
   - Preserve the original path strings, slash normalization and path-matching 
behavior; no public API or network behavior change.
   
   ### Test-first evidence
   - `8c20a96`: pin default/custom root normalization, provider change-path 
recognition, and the exact ZooKeeper consumer path (also assert Nacos identity 
is unchanged); **5 passed on the unmodified implementation**.
   - `05a9e18`: extract ZooKeeper path definitions and update their existing 
callers.
   - `f8f56d3`: match the test filename to the module's `ZooKeeper` naming 
convention.
   
   ### Verification
   - [x] Target branch `main`; PR starts Draft.
   - [x] Focused registry/consumer/Nacos tests: 72 passed.
   - [x] All unit tests on this branch: **410 passed, 0 failed**.
   - [x] Release solution build: passed (4 existing warnings).
   - [x] `git diff --check` and `dotnet format --verify-no-changes` on the two 
new files.
   - [ ] Whole-file `dotnet format --verify-no-changes` for `DubboClient.cs`: 
existing, unrelated whitespace diagnostics remain in this large file; 
deliberately not mass-formatted here. Changed-line indentation has been 
corrected.
   - [ ] GitHub CI and review before marking Ready.
   
   ### Follow-up PRs under #20
   Provider URL keys, consumer registration metadata fields, Nacos service 
naming and default-policy ownership are distinct contracts and will be reviewed 
separately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to