CAICAIIs commented on PR #1054: URL: https://github.com/apache/dubbo-go-pixiu/pull/1054#issuecomment-6717878817
Pushed `523e076`, which addresses the review: - the mode is resolved before the request body is decoded, and `gson` / `protobuf-json` decode with `json.Number`, so integers above 2^53 keep every digit; the map mode decoding is unchanged. - a string argument in the JSON text modes must be valid JSON text; a plain string is rejected while the outbound arguments are built. - `map` is accepted as an alias of `"true"`, and `generic: true` is decoded as a boolean, while `generic: false` is rejected with an explicit error. - the `mapType` limitation in the JSON text modes is documented in the code and in both universality documents. `go build ./...` and `go test ./pkg/client/dubbo/... ./pkg/filter/http/remote/... ./pkg/config/... ./pkg/adapter/dubboregistry/registry/...` pass locally; `gofmt -s` and `imports-formatter` report no diff on a clean copy. The PR stays a draft until the end-to-end sample lands in dubbo-go-pixiu-samples; that pull request is next. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
