AlexStocks commented on code in PR #34: URL: https://github.com/apache/dubbo-net/pull/34#discussion_r4510581345
########## CHANGELOG.md: ########## @@ -0,0 +1,17 @@ +# Changelog / 变更索引 + +This file is a Git index, not a second implementation history. Each link below resolves to a merged PR or Git object; source and tests remain the authority for current behavior. For usage, see the [English README](README.md) or [中文 README](readme_cn.md); for code-reading routes, see [English](Docs/en/architecture/index.md) and [中文](Docs/zh/architecture/index.md). Design rationale belongs in the [RFC convention](Docs/en/rfc.md) and future decision-specific RFCs. + +本文件只提供 Git 索引,不重复编写实施过程。下列链接均指向已合并 PR 或 Git 对象;当前行为仍以源码和测试为准。使用说明参见英文或中文 README,读代码从中英文代码地图进入,架构取舍参见 [RFC 约定](Docs/zh/rfc.md)。 + +## Unreleased / 未发布 + +**No release is asserted here.** The project file declares a package version, but that alone is not a verified Git tag or published release. The [comparison since the import merge](https://github.com/apache/dubbo-net/compare/e10f6d50e97e15bb1164da3c8beccc2380534db5...main) is a moving view of `main`, not a release boundary. When a real tag or release exists, add its verified link and a short user-visible summary; do not relabel these entries as a historical release. + +**此处不声明已经发布。** 项目文件中的包版本号不能单独证明 Git tag 或 Release 已发布。[导入合并后至 main 的比较视图](https://github.com/apache/dubbo-net/compare/e10f6d50e97e15bb1164da3c8beccc2380534db5...main)会随 `main` 变化,不是发行版本边界。将来有可核验的 tag/release,再补链接及简短的用户可见摘要,不倒填虚构版本。 + +- Import provenance / 导入来源:[PR #1](https://github.com/apache/dubbo-net/pull/1), [merge commit](https://github.com/apache/dubbo-net/commit/e10f6d50e97e15bb1164da3c8beccc2380534db5). The import working notes are not the current code guide / 导入工作记录不是当前代码指南。 Review Comment: 🟡 **删除导入审查记录后,未完成的合规待办在代码树里失去入口** 本 PR 删掉的 `Docs/ImportReviewStatus.md`(128 行)不只是「历史工作笔记」,它是目前仓库里唯一明确记录以下未完成事项的地方: - `LICENSE` 末尾 `connect-go` 声明的适用性、原 MIT 来源记录的处理; - SGA/ICLA 归档与其他贡献者授权范围**尚未完成**(该文件原文多次强调「作者授权确认不等于 ASF 完成 IP clearance」,`license.yml` 的注释也写了同一句); - 外网集成实测未通过的结论(ZooKeeper 8/54、Nacos 8/32),以及「不据此声称生产兼容性已全部验证」。 现在这一行只剩 PR #1 与 merge commit 两个链接,「导入工作记录不是当前代码指南」并没有覆盖上述待办。对孵化中的 ASF 仓库,把这些信息只留在 PR #1 的讨论串里,等于仓库自身不再可检索。 **Why:** 后续维护者从仓库出发无法判断捐赠流程是否收口,容易把「导入已合并 + 文件头检查通过」误当成 IP clearance 已完成。 **Suggestion:** 二选一 —— ① 保留该文件,或压成一个精简的 `Docs/import-status.md`(只留「仍待确认的许可行内讨论」表和未完成的验证结论);② 若坚持删除,请在本文件 Unreleased 段补一条显式的 `Outstanding IP clearance` 项,链到具体 issue / 邮件线程,而不是只链 PR #1。 ########## Docs/en/architecture/index.md: ########## @@ -0,0 +1,51 @@ +# Source Navigation: Calls and Updates + +[Documentation home](../index.md) · [中文](../../zh/architecture/index.md) · [User guide](../../../README.md) + +This map describes the **current `main` source used by PR #34**, not a proposed architecture. DubboNet is a consumer of remote Java Providers. The two paths below can be read independently; conditional steps do not run on every request. For API usage, start with the [user guide](../../../README.md); wire details belong to the [native](../protocols/native-dubbo.md) and [Triple](../protocols/triple.md) pages. + +## Request path: `QueryAsync` to result + +```text +DubboClient.QueryAsync + ├─ Java types missing → CreateMetadataInvocationAsync → DubboMetadataManager → signature resolution + └─ QueryInternalAsync → GetRequiredProtocolAsync (best-effort overload check) + → DubboDriverCollection.GetDubboActuatorSuite(reserve: true) + ├─ no driver → ConcurrentGetProviderEndPoints → AddDubboServiceDriver → select again + ├─ driver with no Providers → discover again; retry only if Providers appear + ├─ candidates present but no available actuator → failure result + └─ selected → LoadBalancedInvocation.InvokeAsync → actuator SendQuery → DubboRequestResult +``` + +| Start reading here | Question and next page | +| --- | --- | +| [`DubboClient.QueryAsync` / `QueryInternalAsync`](../../../Clients/DubboClient.cs) | Where do arguments enter? When are types inferred, protocol checked, and initial discovery triggered? → [Client](client.md) | +| [`CreateMetadataInvocationAsync`](../../../Clients/DubboClient.cs) / [`DubboMetadataManager.GetServiceMethodsAsync`](../../../Clients/DubboMetadataManager.cs) | Where do Java signatures come from, and what if they are unavailable? → [Metadata](metadata.md) | +| [`ConcurrentGetProviderEndPoints` / `GetSeviceProviderEndPointsAsync`](../../../Clients/DubboClient.cs) | Who looks up addresses and installs subscriptions? → [Registry and discovery](registry.md) | Review Comment: 🔴 **与 #36 的合并协调目前无法落地:18 个源码链接 + 3 个已删除的方法名 + 状态归属表会一起失效** 我把本 PR head 的 `Docs/` 与 #36 head(`1049623`)的源码树做了交叉核对:本 PR 共 108 处 `.cs` 链接,其中 **18 处**在 #36 下 404(en/zh 各 9)——全部指向被搬走的文件:`Clients/DubboMetadataManager.cs`、`Clients/DubboMethodMetadataResolver.cs`、`Clients/DubboTelnetMetadataResolver.cs`、`Clients/RegistryClient/{MyZookeeper,MyNacos,MultiMyZookeeperStorage}.cs`。 更麻烦的是正文里的方法名:`CreateMetadataInvocationAsync`、`ConcurrentGetProviderEndPoints`、`GetSeviceProviderEndPointsAsync` 在 #36 的整个源码树里 **0 命中**,分别变成 `DubboInvocationMetadataResolver.CreateAsync`、`ProviderDiscovery.GetProviderEndPointsAsync` / `DiscoverAsync`。它们出现在 en/zh 的 `architecture/index.md`(调用链图、本行表格)、`metadata.md`、`registry.md` 共 12 处。本文件第 48 行的状态归属表也把「元数据定义由 `Clients/` 下的 `DubboMetadataManager` 持有」写成现状,而 #36 把所有权交给 `Metadata/` 与 `Registry/ProviderDiscovery`。 **Why:** 两个 PR 的说明都写「后合并者更新链接」,但 #36 的 32 个文件里没有任何 `Docs/`,且 #36 的 issue comment 明确说不会把文档工作混进重构。Markdown 相对路径不参与 Git 冲突,三个 workflow(build / e2e / license)也不检查链接,`.licenserc.yaml` 还 ignore 了 `**/*.md`。按现状无论谁先合并,`main` 都会静默留下死链和过时描述。 **Suggestion:** 合并前定死顺序,并把「路径 + 方法名 + 所有权表」的同步作为一个明确 commit 落进其中一个 PR(推荐让 #34 rebase 到 #36 之上再重写),或直接把两个 PR 合成一个。只补链接不够,方法名和状态表同样要改。 ########## Docs/en/architecture/index.md: ########## @@ -0,0 +1,51 @@ +# Source Navigation: Calls and Updates + +[Documentation home](../index.md) · [中文](../../zh/architecture/index.md) · [User guide](../../../README.md) + +This map describes the **current `main` source used by PR #34**, not a proposed architecture. DubboNet is a consumer of remote Java Providers. The two paths below can be read independently; conditional steps do not run on every request. For API usage, start with the [user guide](../../../README.md); wire details belong to the [native](../protocols/native-dubbo.md) and [Triple](../protocols/triple.md) pages. Review Comment: 💭 **把文档绑定到「PR #34 所基于的 main」在合并当天就过期** `Docs/zh/architecture/index.md:5` 有同一句。读者看到的是已合并进仓库的文档,PR 编号对他没有上下文;而 #36 一合并,这句话反而像在提示「下面可能已经不对了」,却没有指向新版本。 **Suggestion:** 改成带日期 / commit 的表述(例如 `the main source at <sha>` 或 `as of 2026-11`),或去掉来源限定、在页脚写「本页描述随源码变化,以源码与测试为准」——本文件第 28 行其实已经有类似的免责说明了。 ########## Docs/en/code-map.md: ########## @@ -0,0 +1,5 @@ +# Code map moved + +The [source-reading route](architecture/index.md) is now at `Docs/en/architecture/index.md`. This page only preserves existing links; future content belongs in the architecture overview and topic pages. Review Comment: 🟡 **三个「兼容 signpost」没有可兼容的旧链接** `Docs/en/code-map.md`、`Docs/zh/code-map.md`、`Docs/RFC.md` 在本 PR 里都是 `new file mode 100644`;我核过 `main`,这三个路径**都不存在**(#33 已关闭且从未合并)。所以本页的 `This page only preserves existing links / is now at ...`,以及 `Docs/RFC.md:3` 的 `preserves existing links`,描述的是一次没有发生过的迁移:并没有 incoming links 需要保住。PR 描述里「retain `Docs/RFC.md` as a short signpost」「former code-map.md paths are compatibility signposts」同样不准确——是新建,不是保留。 真正需要保留入口的只有 `Docs/NativeDubboProtocol.md` 和 `Docs/TripleProtocol.md`(这两个在 `main` 里确实存在,本 PR 把它们缩成 signpost 是对的)。 **Why:** 三个空壳页会让人误以为仓库曾有过这套目录结构,还给 `Docs/` 导航多添一层无意义跳转。 **Suggestion:** 删掉这三个 new file;若确实想给 #33 曾提议的 URL 预留入口,改成 `reserved for links from an earlier proposal` 之类不声称已有流量的措辞。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
