chaoyoung commented on PR #16586:
URL: https://github.com/apache/dubbo/pull/16586#issuecomment-6758196564

   ### Additional real TCP RPC validation
   
   The earlier validation was component-level only. I temporarily marked this 
PR as draft while adding real provider/consumer coverage.
   
   A direct Triple provider and a Dubbo consumer now exchange requests over a 
loopback TCP listener, with in-JVM invocation disabled, no registry and retries 
disabled. With the released 3.3.7 implementation, Chinese/emoji messages are 
corrupted, literal percent-encoded-looking text changes meaning, and a 
malformed percent message can surface as CANCELLED rather than the original 
error. Plain ASCII rejection reasons survive.
   
   To isolate this patch, the final comparison uses the same released 
dependency classpath and replaces **only CompositeExceptionHandler.class**, 
compiled from this PR. In both ordinary and verbose modes, all 17 error cases 
preserve the expected description and gRPC status code. Each error is followed 
by a successful nonempty RPC: 34 provider invocations per run, no remaining 
failures. The unchanged control fails six description/status checks.
   
   Additional downstream compatibility checks exercised existing 
status-exception conversion and admission implementations through that TCP 
provider, and local HTTP error mapping after the received RPC exception. These 
continue to preserve ASCII reason/status contracts and the caller's existing 
localized fallback behavior. Downstream code, names, packages and raw logs are 
intentionally not included here. Those application checks total 53 passing 
targeted tests and are separate from the 33 upstream tests.
   
   This is a real socket test with provider and consumer in one JVM, not an 
injvm call; it is not a deployed environment or separate-process/load 
benchmark. No production deployment was performed. No production-code changes 
beyond the original encoding patch were needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to