Aias00 commented on code in PR #980:
URL: https://github.com/apache/dubbo-go-pixiu/pull/980#discussion_r4522868090
##########
pkg/server/listener_manager.go:
##########
@@ -117,11 +117,15 @@ func (lm *ListenerManager) gracefulShutdownInit() {
sig := <-signals
logger.Infof("get signal %s, dubbo-go-pixiu will start
shutdown.", sig)
- time.AfterFunc(timeout, func() {
+ timer := time.AfterFunc(timeout, func() {
logger.Warn("Shutdown gracefully timeout, listeners
will shutdown immediately. ")
os.Exit(0)
})
+ // Stop discovery/config watches before draining, so they
cannot publish
+ // new resources during shutdown. The timer still bounds the
whole path.
+ shutdown.RunHooks()
Review Comment:
Addressed in `1d1726dc`. This branch now includes #982 at `76c11f03`,
including the regression for omitted, `0s`, and negative shutdown timeouts;
signal handling and cleanup remain disabled in those cases. The PR body now has
a `release-note` block with `action required`, the positive timeout
requirement, Nacos 2.x/port requirements, and the GuestDao interface migration.
Targeted Go 1.25 race tests and repository-wide golangci-lint v2.4.0 pass. The
develop conflict is resolved while preserving xDS startup error propagation,
Nacos cleanup, and the unsupported-operation fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]