xiaobaicai66695 opened a new pull request, #1084: URL: https://github.com/apache/dubbo-go-pixiu/pull/1084
Refs #1082 ## Scope - Register the AdminCluster schema with a Static default and the discovery types accepted by the current runtime. - Validate the name, type, endpoint address, and port (1–65535) with stable field paths. Reject unknown editable fields, including spec.id. - Convert between the Admin object and the existing flat Cluster YAML. Keep the runtime ID separate from form data and let the publisher attach it. - Add unit tests for valid values, invalid fields, port boundaries, unknown fields, and legacy YAML compatibility. This PR covers the model and conversion acceptance criteria only. It does not change the Cluster Manager, load balancing, Listener semantics, or the existing Cluster CRUD API. ## Interface decisions for the next PRs - Drafts need an independent stable draft ID. Empty metadata.name is allowed in storage and rejected by strict validation before preview or publish. Runtime Cluster ID stays system managed. - The old /config/api/cluster CRUD endpoints continue to write the existing runtime keys. The lifecycle implementation must reconcile direct legacy writes with draft/published status and history; the old delete path must enforce the same deletion protection. - Published runtime Clusters are the source of truth for name uniqueness. Deletion checks published Listener references and rechecks them when committing concurrent changes. - Validation paths are metadata.name, spec.type, spec.endpoint.address, and spec.endpoint.port. A publish transaction atomically changes the related etcd keys; xDS application is asynchronous and will be checked by the later integration test. ## Verification - go test ./pkg/config/schema ./admin/logic ./admin/controller/configInfo - GOPROXY=https://proxy.golang.org,direct go test ./admin/xds - go vet ./pkg/config/schema - git diff --check Draft APIs, publish/history/rollback, deletion protection, UI, and runtime integration tests remain for PRs 2–4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
