bosprimigenious commented on PR #1080:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1080#issuecomment-6771745376
Thanks for the detailed review. Taking the 🟡 seriously rather than deferring
it: I'll add the `reflect.ValueOf(v).Kind()` / `IsNil()` guard before the
switch so `map[any]any(nil)` and `[]any(nil)` serialize as `null` instead of
`{}` / `[]`, and keep the existing path for `None`, empty string and `False`.
For the 💠I'll add a short comment stating the decision either way (fixed
here, or deliberately deferred) so the next reader does not have to guess. I'll
push the update on this branch and re-run the package tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]